Solution #824
Open
Solution #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArsenPidhoretskyi
suggested changes
Oct 26, 2023
app/main.py
Outdated
Comment on lines
17
to
29
| for index1 in range(len(person_list)): | ||
| if "wife" in people[index1]: | ||
| if people[index1]["wife"] is not None: | ||
| for index2 in range(len(people)): | ||
| if people[index1]["wife"] == people[index2]["name"]: | ||
| person_list[index1].wife = person_list[index2] | ||
|
|
||
| elif "husband" in people[index1]: | ||
| if people[index1]["husband"] is not None: | ||
| for index2 in range(len(people)): | ||
| if people[index1]["husband"] == people[index2]["name"]: | ||
| person_list[index1].husband = person_list[index2] | ||
| return person_list |
There was a problem hiding this comment.
So hard realization...... First of all why do you iterate through index? Also, why do you use loop into loop?
You have Person.people dict use it and only one loop here
There was a problem hiding this comment.
I use the first loop to add attributes to each person and the second to find husband/wife for him, I don't know how to make it by one loop
There was a problem hiding this comment.
I use index because it is the same in the dict and in the list or person and it is easy to iterate so -__-
…е проходило по довжині flake8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.